Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior preparation of Unitary and Functional Test schemes. First Stage #2256

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

NeftaliYagua
Copy link
Contributor

@NeftaliYagua NeftaliYagua commented Feb 2, 2025

Description

In this deep planned effort to prepare the source to be updated, the unit and functional tests of the project are carried out.
The present changes are the first stage of a series of commits necessary to refactor the source so that it is updateable, in this step they correct that each scheme has the necessary resource to write the corresponding tests. Which will allow us to automatically measure whether the progressive update allows the source to be updated.

Unit and functional tests are a series of code routines that allow checking the integrity of the elements developed in each module, therefore it is an extensive and somewhat complicated job, I urge the project developers to ignore the changes that are happening in these files, which generally speaking are not the build files of the project, therefore they will not affect the development, but to whoever approves the pull request, I strongly ask you to verify that the edits applied to the main classes module do not clash with changes from other contributors.

If you have questions about the changes that have occurred here, you can keep the pull request open and have the discussion before performing the merge, however, if you are already familiar with Angular unit tests, you can review and merge them, I guarantee that I do not upload changes without review in great detail, and that I have barely touched on the minimum number of core files necessary, this registry generally handles a code testing context.

  • Schema exceptions have been added since mat modules are not native Angular schemas. CUSTOM_ELEMENTS_SCHEMA, NO_ERRORS_SCHEMA
  • I have added the Mat*Module, ReactiveFormsModule, HttpClientModule and RouterTestingModule in cases where the module has been loaded in the controller.

These changes are not finished yet, because there are more than 700 pending corrections and all of them must be checked, please be patient as work is being done at an accelerated rate on these corrections.

Related issues and discussion

Discusion #2252
#No Issue related

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@NeftaliYagua
Copy link
Contributor Author

NeftaliYagua commented Feb 5, 2025

TOTAL: 519 FAILED (72.18%), 200 SUCCESS (27.82%)
You can merge the changes, I'll rest for a couple of days and continue on another pull request.

This pull request is ready to be joined, I will rest for a couple of days while they review it, 27.82% done is a great progress, considering everything that remains to be done, this from the first stage which is about making all the testing schemes are available for building unit tests and functional tests. After this step, the errors that exist in the current code will be clearly seen, which will facilitate their progressive correction.

@NeftaliYagua
Copy link
Contributor Author

It is necessary at this point to wait to merge the test reviews, in order to start correcting the errors in the code in the development context, since in the Testing context a large percentage of the primary reviews are loaded, so that the errors in the code can already be identified. I will wait for this Pull Request to be applied to begin designing the data interfaces, and the corrections in the code to the errors found.
Please try to prioritize this pull request to proceed with the source code fixes.

@NeftaliYagua NeftaliYagua reopened this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant