[chore] Update pre commit hooks, copyright dates for 2025, Doc-QA checks, mypy version pin #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1699 +/- ##
===========================================
+ Coverage 85.62% 85.64% +0.01%
===========================================
Files 151 151
Lines 15531 15531
===========================================
+ Hits 13298 13301 +3
+ Misses 2233 2230 -3 ☔ View full report in Codecov by Sentry. |
omad
force-pushed
the
chore/pre-commit-and-copyright-dates
branch
3 times, most recently
from
8d60354 to
1ea0922
Compare
While it does catch some sensible errors, doctor-rst is written with a focus on ReST usage within the PHP ecosystem, and some defaults are wrong.
Previously, the DOC QA workflow only ran once, when a PR was first opened, and then if more commits were pushed, it's results were ignored and it never ran again. As convenient as this was, for not preventing PRs being merge for failing Doc QA builds. It's also completely useless! This split makes the RTD doc preview link comment run once on a new PR with permission to update the description, and the Doc QA run on any change to a PR.
omad
force-pushed
the
chore/pre-commit-and-copyright-dates
branch
from
83e8099 to
776cdd5
Compare
omad
requested review from
alexgleith,
SpacemanPaul,
caitlinadams and
Ariana-B
omad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
It's a new year, so update all the copyright dates with the new year, and the pre-commit hooks are out of date.
and after fixing that
The Doc QA CI checks were failing, and not running all the time. So fix the spelling mistakes, fix the doctor-rst configuration, update the version of doctor-rst, and update the CI build file.
and after fixing that
The lint CI check was failing due to a new version of
mypy, so pin that.and after fixing that
I noticed that all the build/test CI jobs were running twice against PRs, so fix that too.
📚 Documentation preview 📚: https://datacube-core--1699.org.readthedocs.build/en/1699/