Update standard workflow files. #2867
Conversation
The .github/workflows/commitlint.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org.
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2867 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 235 235
Lines 4240 4240
Branches 1029 1029
=======================================
Hits 3936 3936
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
|
|
||
| - name: Run commitlint | ||
| uses: wagoid/commitlint-github-action@v5 | ||
| uses: openedx/.github/.github/workflows/commitlint.yml@master |
There was a problem hiding this comment.
This is fixed in the latest version of the commit linter so the override is no longer needed.
| # This step is needed to fix https://github.com/conventional-changelog/commitlint/issues/3256 | ||
| - name: Remove tsconfig file | ||
| run: rm tsconfig.json |
There was a problem hiding this comment.
https://github.com/openedx/.github/blob/master/.github/workflows/commitlint.yml does not include this step.
The issue mentioned here (conventional-changelog/commitlint#3256) is still open, but I tested the repro steps (commitlint --from HEAD~2 --to HEAD) locally and found no errors.
The environment mentioned in the linked issue was:
commitlint --version |
16.3.0 |
git --version |
2.36.1 |
node --version |
18.4.0 |
After running nvm use, my local environment was
commitlint --version |
18.4.3 |
git --version |
2.42.0 |
node --version |
18.18.2 |
The commitlint gh action uses commitlint version ^18.2.0, and node version 20.9.0, so overall this feels safe to remove.
|
🎉 This PR is included in version 21.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 22.0.0-alpha.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR was created automatically by the
repo_checkstool.