fixes for Jacob review

Signed-off-by: Laurent ARNAL <[email protected]>
openhab · Feb 5, 2025 · d43ab2a · d43ab2a
1 parent bd721b8
commit d43ab2a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/....binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java b/....binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
@@ -161,12 +161,12 @@ public void initialize() {
         // update the timezone if not set to default to openhab default timezone
         Configuration thingConfig = getConfig();
 
-        Object val = thingConfig.get("timezone");
-        if (val == null || "".equals(val)) {
+        String val = (String) thingConfig.get("timezone");
+        if (val == null || val.isBlank()) {
             zoneId = this.timeZoneProvider.getTimeZone();
             thingConfig.put("timezone", zoneId.getId());
         } else {
-            zoneId = ZoneId.of((String) val);
+            zoneId = ZoneId.of(val);
         }
 
         updateConfiguration(thingConfig);

diff --git a/bundles/org.openhab.binding.linky/src/main/resources/OH-INF/i18n/linky.properties b/bundles/org.openhab.binding.linky/src/main/resources/OH-INF/i18n/linky.properties
@@ -14,6 +14,8 @@ thing-type.config.linky.linky.internalAuthId.label = Auth ID
 thing-type.config.linky.linky.internalAuthId.description = Authentication ID delivered after the captcha (see documentation).
 thing-type.config.linky.linky.password.label = Password
 thing-type.config.linky.linky.password.description = Your Enedis Password
+thing-type.config.linky.linky.timezone.label = timezone
+thing-type.config.linky.linky.timezone.description = The timezone associated with your Point of delivery. Will default to openHAB default timezone. You will need to change this if your Linky is located in a different timezone that your openHAB location. You can use an offset, or a label like Europe/Paris
 thing-type.config.linky.linky.username.label = Username
 thing-type.config.linky.linky.username.description = Your Enedis Username
 
@@ -41,6 +43,6 @@ channel-type.linky.power.label = Yesterday Peak Power
 channel-type.linky.power.description = Maximum power usage yesterday
 channel-type.linky.timestamp.label = Timestamp
 
-# Thing status descriptions
+# thing status descriptions
 
 offline.config-error-mandatory-settings = Username, password and authId are mandatory.
diff --git a/bundles/org.openhab.binding.linky/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.linky/src/main/resources/OH-INF/thing/thing-types.xml
@@ -37,9 +37,9 @@
 			<parameter name="timezone" type="text" required="false">
 				<label>timezone</label>
 				<description>The timezone associated with your Point of delivery.
-					Will default to openhab default timezone.
+					Will default to openHAB default timezone.
 					You will
-					need to change this if your linky is located in a different timezone that your openhab location.
+					need to change this if your Linky is located in a different timezone that your openHAB location.
 					You can use an
 					offset, or a label like Europe/Paris</description>
 			</parameter>