Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluetooth] Switch to fork of gatt parser library in order to fix incompatibility with xstream #13128

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

kaikreuzer
Copy link
Member

See #10278 (comment)

Signed-off-by: Kai Kreuzer [email protected]

@kaikreuzer kaikreuzer requested a review from a team July 14, 2022 20:45
@kaikreuzer kaikreuzer requested a review from cpmeister as a code owner July 14, 2022 20:45
@kaikreuzer kaikreuzer changed the title Switch to fork of gatt parser library in order to fix incompatibility with xstream [bluetooth] Switch to fork of gatt parser library in order to fix incompatibility with xstream Jul 14, 2022
@kaikreuzer
Copy link
Member Author

Hm, I'm not sure why SAT complains about errors in the external library.
@wborn Can this somehow be ignored?

@wborn
Copy link
Member

wborn commented Jul 15, 2022

I'm not sure why SAT complains about errors in the external library.

This library is embedded into the bundle so the library classes now also end up in target/classes/org/openhab which are configured to be analyzed as Spotbugs inspects bytecode.

Can this somehow be ignored?

You can have a look at how SAT is configured in OHC to suppress some SpotBugs findings.

Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
@kaikreuzer
Copy link
Member Author

Thanks @wborn, that helped!

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jlaur jlaur merged commit d814640 into openhab:main Jul 19, 2022
@jlaur jlaur added this to the 3.4 milestone Jul 19, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
…ompatibility with xstream (openhab#13128)

* Switch to fork of gatt parser library in order to fix incompatibility with xstream
* Add SAT suppressions
* Add gson dependency

Signed-off-by: Kai Kreuzer <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…ompatibility with xstream (openhab#13128)

* Switch to fork of gatt parser library in order to fix incompatibility with xstream
* Add SAT suppressions
* Add gson dependency

Signed-off-by: Kai Kreuzer <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…ompatibility with xstream (openhab#13128)

* Switch to fork of gatt parser library in order to fix incompatibility with xstream
* Add SAT suppressions
* Add gson dependency

Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
…ompatibility with xstream (openhab#13128)

* Switch to fork of gatt parser library in order to fix incompatibility with xstream
* Add SAT suppressions
* Add gson dependency

Signed-off-by: Kai Kreuzer <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…ompatibility with xstream (openhab#13128)

* Switch to fork of gatt parser library in order to fix incompatibility with xstream
* Add SAT suppressions
* Add gson dependency

Signed-off-by: Kai Kreuzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants