Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pythonscripting][wip] initial release #18229

Open
wants to merge 132 commits into
base: main
Choose a base branch
from

Conversation

HolgerHees
Copy link
Contributor

@HolgerHees HolgerHees commented Feb 4, 2025

Initial release with detailed description in marketplace

https://community.openhab.org/t/python3-scripting/161945

and it has still one major known issues #18054 (comment)

in the final version, before I merge, I will rebase the project to clean the history.

HolgerHees and others added 30 commits December 18, 2024 16:26
Working with "info is null"

Working - occasional "info" is null
Graal engine working - occasional "info" is null
Working with "info is null"

Working - occasional "info" is null
added "py" extension in getExtension

First pass at mirroring jsscripting
Created own GraalPythonScriptEngine based on the GraalJSScriptEngine

Working - with exception of regex language
updated working/lib directories to find modules in lib folder
added python standard libraries

Working version
added "py" extension to getExtension in factory
Added injection of scope hashmap
inserted scope variables from the scopeValues method in the component
… - not needed since one is created in OpenhabGraalPythonScriptEngine

cleanup
Eliminate creating a default engine in GraalPythonScriptEngineFactory…
@HolgerHees HolgerHees changed the title Pythonscripting [pythonscripting] initial release Feb 4, 2025
@HolgerHees HolgerHees changed the title [pythonscripting] initial release [pythonscripting][wip] initial release Feb 5, 2025
@HolgerHees HolgerHees marked this pull request as ready for review February 5, 2025 15:44
@HolgerHees HolgerHees requested a review from a team as a code owner February 5, 2025 15:44
@ccutrer
Copy link
Contributor

ccutrer commented Feb 6, 2025

FYI, I plan to use GraalPython with the MQTT Home Assistant binding so that I can run actual Jinja, and not Jinjava which has had significant compatibility issues with more complex templates that devices can provide. We should probably avoid having multiple copies of the GraalPython bundles loaded, so I've started work on OSGi-ifying the Python specific bundles here. You can reference #18053 for how to begin depending on the OSGi-ified versions of bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants