Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mqtt.homeassistant] Only subscribe to topics for linked channels #18239

Merged
merged 2 commits into from
Feb 13, 2025
Merged

[mqtt.homeassistant] Only subscribe to topics for linked channels #18239

merged 2 commits into from
Feb 13, 2025

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Feb 7, 2025

Closes #17650

@ccutrer ccutrer marked this pull request as ready for review February 10, 2025 17:57
@ccutrer ccutrer requested a review from antroids as a code owner February 10, 2025 17:57
@ccutrer
Copy link
Contributor Author

ccutrer commented Feb 10, 2025

I've been running this successfully for several days now (and also confirmed that it doesn't subscribe to at least the bulk of my unlinked channels).

lsiepel
lsiepel approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean. Thanks, LGTM

@lsiepel lsiepel merged commit 01cb892 into openhab:main Feb 13, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Feb 13, 2025
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Feb 13, 2025
@ccutrer ccutrer deleted the mqtt-homeassistant-lazy-subscriptions branch February 13, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@antroids antroids Awaiting requested review from antroids antroids is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[mqtt.homeassistant] Don't subscribe to topics for unlinked channels
2 participants
@ccutrer @lsiepel