[casokitchen] Initial contribution #18243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
Signed-off-by: Bernd Weymann <[email protected]>
jlaur
added
the
new binding
This comment was marked as outdated.
This comment was marked as outdated.
lsiepel
requested changes
Feb 12, 2025
| @Activate | ||
| public CasoKitchenHandlerFactory(final @Reference HttpClientFactory httpClientFactory, | ||
| final @Reference TimeZoneProvider tzp) { | ||
| httpClient = httpClientFactory.getCommonHttpClient(); |
There was a problem hiding this comment.
Please store the factory and create a httpclient for each time a thing handler is created.
Comment on lines
+16
to
+17
| <label>Desired Temperature</label> | ||
| <description>Desired Zone Temperature</description> |
There was a problem hiding this comment.
Not wrong, but a more common convention is to use Target vs Desired.
| } | ||
| } | ||
|
|
||
| private boolean checkConfig() { |
There was a problem hiding this comment.
Within the flow it works as expected, but io would like to ask you to refactor this. The method is not only checking the config (as it's name suggests), it is also setting the Thing state.
- Maybe return the reason and set the thing state in the initialize method
- Another fix could be to change the method name.
- On top of the above i would propose to change the logich a bit:
- make use of
isBlank()instead of!= EMPTY - prevend nested if's. : check condition and exit /return immediate.
| if (responseStatus == 200) { | ||
| updateState(new ChannelUID(thing.getUID(), group, LIGHT), OnOffType.from(lr.lightOn)); | ||
| } else { | ||
| logger.info("Call to {} responded with status {} reason {}", LIGHT_URL, response.getStatus(), |
There was a problem hiding this comment.
Suggested change
| logger.info("Call to {} responded with status {} reason {}", LIGHT_URL, response.getStatus(), | |
| logger.warn("Call to {} responded with status {} reason {}", LIGHT_URL, response.getStatus(), |
Comment on lines
+179
to
+185
| Request req = httpClient.POST(LIGHT_URL); | ||
| req.header(HttpHeader.CONTENT_TYPE, "application/json"); | ||
| req.header(HTTP_HEADER_API_KEY, configuration.apiKey); | ||
| req.content(new StringContentProvider(GSON.toJson(lr))); | ||
| try { | ||
| ContentResponse response = req.timeout(60, TimeUnit.SECONDS).send(); | ||
| int responseStatus = response.getStatus(); |
There was a problem hiding this comment.
Would be nice if you can extract the http request/response handling outside of this method. and make it somewhat generic for future use.
Comment on lines
+209
to
+217
| StatusRequest requestContent = new StatusRequest(configuration.deviceId); | ||
| Request req = httpClient.POST(STATUS_URL); | ||
| req.header(HttpHeader.CONTENT_TYPE, "application/json"); | ||
| req.header(HTTP_HEADER_API_KEY, configuration.apiKey); | ||
| req.content(new StringContentProvider(GSON.toJson(requestContent))); | ||
| try { | ||
| ContentResponse contentResponse = req.timeout(60, TimeUnit.SECONDS).send(); | ||
| int responseStatus = contentResponse.getStatus(); | ||
| String contentResult = contentResponse.getContentAsString(); |
There was a problem hiding this comment.
See other comment about extracting request/response. Maybe extracting it to an additionl class is a biut too much, but atleast extract it to another method.
| </channel-type> | ||
| <channel-type id="hint"> | ||
| <item-type>String</item-type> | ||
| <label> Hint</label> |
There was a problem hiding this comment.
Suggested change
| <label> Hint</label> | |
| <label>Hint</label> |
| <channel-type id="hint"> | ||
| <item-type>String</item-type> | ||
| <label> Hint</label> | ||
| <description> Textual hint for device status</description> |
There was a problem hiding this comment.
Suggested change
| <description> Textual hint for device status</description> | |
| <description>Textual hint for device status</description> |
| Instant startWaiting = Instant.now(); | ||
| while (states.size() < stateCount && startWaiting.plus(5, ChronoUnit.SECONDS).isAfter(Instant.now())) { | ||
| try { | ||
| wait(250); |
There was a problem hiding this comment.
Can you share some insights to why there a hardcoded wait?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding to connect CASO Smart Kitchen devices.
Currently wine coolers are supported, development team told me more devices will follow.
Topic was discussed in forum and binding is present on Marketplace.