Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lgtvserial] Update documentation and fix labels/descriptions #18253

Merged
merged 8 commits into from
Feb 12, 2025
Merged

[lgtvserial] Update documentation and fix labels/descriptions #18253

merged 8 commits into from
Feb 12, 2025

Conversation

mlobstein
Copy link
Contributor

The PR makes the following improvements to the README and labels & descriptions:

  • Improve README content, grammar, punctuation, etc.
  • Add missing Thing Configuration parameters table
  • Fix incorrect or missing ids and normalize descriptions in the Channels table
  • Fix broken links to reference documents
  • Fix incorrect or awkward thing and channel labels & descriptions

No code changes were made.

@mlobstein
Update documentation
4d69bd9 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
Update documentation
b81a05c 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein mlobstein requested a review from fa2k as a code owner February 12, 2025 02:06
@mlobstein
Capitalize Set Id
295ad8f 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
Add default Set Id
371fb12 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
serial port-> control port
6a05646 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
phrasing
dcf012c 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
fix some words
438bbe1 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
ID capital
b356a4a 
Signed-off-by: Michael Lobstein <[email protected]>
jlaur
jlaur approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the many cleanups and improvements, LGTM!

@jlaur jlaur changed the title [lgtvserial] Update documentation [lgtvserial] Update documentation and fix labels/descriptions Feb 12, 2025
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Feb 12, 2025
@jlaur jlaur merged commit e95fb3c into openhab:main Feb 12, 2025
2 checks passed
@jlaur jlaur added this to the 5.0 milestone Feb 12, 2025
@mlobstein mlobstein deleted the lgtvserial_doc branch February 12, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@fa2k fa2k Awaiting requested review from fa2k fa2k is a code owner

Assignees
No one assigned
Labels
documentation enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mlobstein @jlaur