[luxtronikheatpump] Add power consumption channel #18254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clemens Eberwein <[email protected]>
sgiehl
requested changes
Feb 12, 2025
bundles/org.openhab.binding.luxtronikheatpump/src/main/resources/OH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
...hab.binding.luxtronikheatpump/src/main/resources/OH-INF/i18n/luxtronikheatpump_de.properties
Outdated
Show resolved
Hide resolved
…es/OH-INF/thing/channels.xml Co-authored-by: Stefan Giehl <[email protected]> Signed-off-by: negesti <[email protected]>
Signed-off-by: Clemens Eberwein <[email protected]>
lsiepel
requested changes
Feb 12, 2025
lsiepel
added
the
enhancement
jlaur
reviewed
Feb 12, 2025
...penhab.binding.luxtronikheatpump/src/main/resources/OH-INF/i18n/luxtronikheatpump.properties
Outdated
Show resolved
Hide resolved
…n i18n, remove duplicate channel from README.md Signed-off-by: Clemens Eberwein <[email protected]>
… existing Hot Gas Temperature channels Signed-off-by: Clemens Eberwein <[email protected]>
|
Sry for the poor quality of the PR and wasting your time :( I re-generated the properties using the i18n plugin as @jlaur suggested and updated label for the label for |
lsiepel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With Firmware V3.90.x (not sure about the exact version) addional channels are available (261-268)
Especially channel 268 "Power Consumption" is now avaible and gives details about the actual (electric) power consumption of the heatpump.
Testing
Tested the new channels with a local docker installation for the last ~ 12 hours without any errors/exceptions