Explanation of suggested add-ons #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an explanation of the new suggested add-ons feature. Note: I added a new screen-shot image, but I am not sure if it is automatically added to the PR commit. Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Andrew Fiddian-Green <[email protected]>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@lolodomo you want to merge this in v4.1 |
stefan-hoehn
requested changes
Dec 17, 2023
There was a problem hiding this comment.
Thanks for the contribution, Andrew. Please see my comments.
I have requested @Confectrician to also have comment on the that particular image link.
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
|
Looks pretty good now: https://deploy-preview-2179--openhab-docs-preview.netlify.app/docs/configuration/addons.html Thanks Andrew. |
stefan-hoehn
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an explanation of the new suggested add-ons feature.
Note: I added a new screen-shot image, but I am not sure if it is automatically added to the PR commit.
Signed-off-by: Andrew Fiddian-Green [email protected]