Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[huesync][binding][logo] Add logo for huesync binding to repository #2408

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

pgfeller
Copy link
Contributor

Fixes #2407

Signed-off-by: Patrik Gfeller [email protected]

Copy link

netlify bot commented Nov 17, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 6577aff
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/673a345f870e2b00088de11a
😎 Deploy Preview https://deploy-preview-2408--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lsiepel
Copy link
Contributor

lsiepel commented Dec 5, 2024

Ready: (openhab/openhab-addons#16516)

@stefan-hoehn
Copy link
Contributor

Why do we have both #2407 and #2408? I am confused 😄

@lsiepel
Copy link
Contributor

lsiepel commented Dec 8, 2024

Why do we have both #2407 and #2408? I am confused 😄

Haha 2407 is an issue 2408 a PR. In most repo’s we prefer to have an issue (for discussion) before the PR. Guess @pgfeller followed that ‘habit’, but yes not needed for this repo.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Patrik, lgtm

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Dec 8, 2024
@stefan-hoehn stefan-hoehn merged commit 9b148b7 into openhab:main Dec 8, 2024
5 checks passed
@stefan-hoehn
Copy link
Contributor

Haha 2407 is an issue 2408 a PR.

In german we say "Wer lesen kann ist klar im Vorteil" ("Those who can read have a clear advantage") 😜 Thx, I should have looked a bit more closely 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[huesync][binding][logo] Add logo for huesync binding to repository
3 participants