Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set nginx proxy HTTP version to 1.1 in reverse proxy config #2429

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

florian-h05
Copy link
Contributor

HTTP 1.1 is required for WebSockets to work.
As the new log viewer uses the log WebSocket, it is required to modify the reverse proxy config.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-3-release-discussion/160888/66

Copy link

netlify bot commented Dec 17, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit d3e4cc2
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/676130ac249a86000809bfef
😎 Deploy Preview https://deploy-preview-2429--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florian-h05
Copy link
Contributor Author

@kaikreuzer Can you please modify the release notes and (properly to the breaking changes section even though this is not really breaking) that when using nginx as reverse proxy, it is required to set the proxy HTTP version to 1.1 like in this PR?

@florian-h05
Copy link
Contributor Author

@mstormi
IIRC openHABian provides an option to install and configure nginx, so this here might be interesting for you.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-hoehn stefan-hoehn merged commit 9952883 into openhab:main Dec 17, 2024
4 checks passed
@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Dec 17, 2024
@florian-h05 florian-h05 deleted the patch-1 branch December 17, 2024 08:31
@mstormi
Copy link
Contributor

mstormi commented Dec 17, 2024

thx for the heads up. I've added that to openHABian's default nginx config

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-x-and-log-viewer-behind-nginx-proxy/161222/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants