Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure the plugin to fail on any severity #478

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

david-m-s
Copy link
Contributor

This is necessary to ease the integration to cicd with requirements to not pass if any static code violation is found, without needing to configure the checkstyle, pmd and findbugs in depth to produce only error level. It s hard to configure each individual plugin (if at all possible) and can be difficult to maintain regarding future versions.

@david-m-s david-m-s requested a review from a team as a code owner January 15, 2025 12:15
@david-m-s david-m-s force-pushed the allow-to-fail-on-different-severities branch from a3fd025 to 6229b3d Compare January 17, 2025 08:02
…ues. This is necessary to ease the integration to cicd with requirements to not pass if any static code violation is found, without needing to configure the checkstyle, pmd and findbugs in depth to produce only error level, which is hard to do and can be difficult to maintain regarding future versions.

Signed-off-by: David Mas <[email protected]>
@david-m-s david-m-s force-pushed the allow-to-fail-on-different-severities branch from 6229b3d to c7fc89a Compare January 17, 2025 08:07
@wborn wborn linked an issue Jan 19, 2025 that may be closed by this pull request
David Mas added 2 commits January 20, 2025 10:54
Signed-off-by: David Mas <[email protected]>
Signed-off-by: David Mas <[email protected]>
@david-m-s david-m-s force-pushed the allow-to-fail-on-different-severities branch from 1d09b54 to 3ff3c6e Compare January 20, 2025 13:18
@david-m-s david-m-s requested a review from wborn January 22, 2025 09:56
david-m-s and others added 2 commits January 28, 2025 11:30
…ortMojoTest.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: David Mas <[email protected]>
…ortMojoTest.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: David Mas <[email protected]>
@david-m-s david-m-s requested a review from wborn January 28, 2025 11:16
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement! 👍

@wborn wborn merged commit 33e858f into openhab:main Jan 28, 2025
2 checks passed
@wborn wborn added this to the 0.18.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to fail the build on any severity issues
2 participants