Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandate DCQL instead of PE; all DCQL features are mandatory #151

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

c2bo
Copy link
Member

@c2bo c2bo commented Jan 7, 2025

Closes #140.

I guess the biggest discussion point currently missing would be the mandatory DCQL features (also closes #142).

(also adds missing document history if you are wondering about that part)

@tlodderstedt tlodderstedt requested a review from leecam January 9, 2025 16:29
@tlodderstedt
Copy link
Contributor

WG Call 9.1.25

  • Consensus to make DCQL as it is specified MTI in HAIP and simplify the text to make it MTI on the overall level (which means to remove DCQL related text in the mdoc and sd-jwt sections)

@c2bo
Copy link
Member Author

c2bo commented Jan 14, 2025

WG Call 9.1.25

  • Consensus to make DCQL as it is specified MTI in HAIP and simplify the text to make it MTI on the overall level (which means to remove DCQL related text in the mdoc and sd-jwt sections)

If we agree in #142, that initially there is no profiling of DCQL required, then I think the PR is fine as is and I would just additionally remove the text referencing #142 for sd-jwt and DC API.

@Sakurann Sakurann changed the title Mandate DCQL instead of PE Mandate DCQL instead of PE; all DCQL features are mandatory Jan 21, 2025
@Sakurann
Copy link
Contributor

re-requesting reviews since on top of DCQL being mandatory, all DCQL features are made mandatory

@babisRoutis
Copy link

re-requesting reviews since on top of DCQL being mandatory, all DCQL features are made mandatory

Is there any text (in this PR) related to "all DCQL features are made mandatory" or the reference to OpenId4VP implies this?
If the mandatory features are implied, perhaps there is some uncertainty, given that DCQL is still evolving.

PS: BTW, I am not suggesting that HAIP should list the mandatory features.

@Sakurann
Copy link
Contributor

Sakurann commented Jan 23, 2025

@babisRoutis I think that by not saying which features are mandatory, that means that all are mandatory, but i think i agree we can make that clearer, though I don't know what text can best say that...

@Sakurann Sakurann merged commit 73620d0 into main Jan 23, 2025
2 checks passed
@babisRoutis
Copy link

@babisRoutis I think that by not saying which features are mandatory, that means that all are mandatory, but i think i agree we can make that clearer, though I don't know what text can best say that...

Given that

  • OpenId4VP, which defines DCQL doesn't provide "names" for each feature and doesn't make a distinction between mandatory/optional features
  • DCQL developedment was/is driven by a well-defined set of use-cases

I don't think that there is a good reason to explicitly define features to HAIP.

PR looks good as it is now (except the title 😄 )

Sakurann pushed a commit that referenced this pull request Jan 28, 2025
6 approvals. agreement to merge as-is during the WG call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mandated DCQL features change HAIP to mandate DCQL
7 participants