Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318636: Add jcmd to print annotated process memory map #1415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ansteiner
Copy link

@ansteiner ansteiner commented Feb 19, 2025

Hi all,

This pull request contains a backport of commit 6f863b2a from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 13 Nov 2023 and was reviewed by Johan Sjölen and Gerard Ziemski.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318636 needs maintainer approval

Issue

  • JDK-8318636: Add jcmd to print annotated process memory map (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1415/head:pull/1415
$ git checkout pull/1415

Update a local copy of the PR:
$ git checkout pull/1415
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1415

View PR using the GUI difftool:
$ git pr show -t 1415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1415.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2025

👋 Welcome back asteiner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6f863b2a1baa67deb2a7b33fcd93d272aea01812 8318636: Add jcmd to print annotated process memory map Feb 19, 2025
@openjdk
Copy link

openjdk bot commented Feb 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 19, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2025

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Feb 19, 2025

@ansteiner Please enable GHA testing for your fork. Thanks!

See: https://github.com/openjdk/jdk21u-dev/pull/1415/checks?check_run_id=37469345959

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Where there any changes needed apart from the fact that the NMT sources moved to share/nmt ?

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

⚠️ @ansteiner This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@ansteiner
Copy link
Author

Looks good. Where there any changes needed apart from the fact that the NMT sources moved to share/nmt ?

Only in the tests, because the OutputAnalyzer in 21 is missing the convenience contains method.

@ansteiner
Copy link
Author

/approval request We want to have this very helpful supportability feature in jdk21u-dev too.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@ansteiner
8318636: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants