-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318636: Add jcmd to print annotated process memory map #1415
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back asteiner! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
@ansteiner Please enable GHA testing for your fork. Thanks! See: https://github.com/openjdk/jdk21u-dev/pull/1415/checks?check_run_id=37469345959 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Where there any changes needed apart from the fact that the NMT sources moved to share/nmt ?
|
Only in the tests, because the OutputAnalyzer in 21 is missing the convenience contains method. |
/approval request We want to have this very helpful supportability feature in jdk21u-dev too. |
@ansteiner |
Hi all,
This pull request contains a backport of commit 6f863b2a from the openjdk/jdk repository.
The commit being backported was authored by Thomas Stuefe on 13 Nov 2023 and was reviewed by Johan Sjölen and Gerard Ziemski.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1415/head:pull/1415
$ git checkout pull/1415
Update a local copy of the PR:
$ git checkout pull/1415
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1415/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1415
View PR using the GUI difftool:
$ git pr show -t 1415
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1415.diff
Using Webrev
Link to Webrev Comment