Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342075: HttpClient: improve HTTP/2 flow control checks #1428

Open
wants to merge 2 commits into
base: pr/1426
Choose a base branch
from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Feb 21, 2025

Please review the backport of JDK-8342075

Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java

Requires JDK-8317808 [1] as a prerequisite to fixing the hanging of the new tests.

Also, new tests require Http2TestExchange::getConnectionKey() method added by JDK-8335181 [2].

test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java, test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java test classes are updated to add getConnectionKey() implementation

All jtreg tests for java.net.httpclient are passed

[1] - #1426
[2] - openjdk/jdk@720b446#diff-c18c2a070038409f25c08e13c174a95f33840e2deddcc29f6d8306de572a618b


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8342075 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8350602 to be approved

Integration blocker

 ⚠️ Dependency #1426 must be integrated first

Issues

  • JDK-8342075: HttpClient: improve HTTP/2 flow control checks (Bug - P4)
  • JDK-8350602: HttpClient: improve HTTP/2 flow control checks (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1428/head:pull/1428
$ git checkout pull/1428

Update a local copy of the PR:
$ git checkout pull/1428
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1428

View PR using the GUI difftool:
$ git pr show -t 1428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1428.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into pr/1426 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b0ac633b2d0076d64b463b2a6ce19abf6b12c50f 8342075: HttpClient: improve HTTP/2 flow control checks Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant