8342075: HttpClient: improve HTTP/2 flow control checks #1428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the backport of JDK-8342075
Almost clean backport except for the import section of src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
Requires JDK-8317808 [1] as a prerequisite to fixing the hanging of the new tests.
Also, new tests require Http2TestExchange::getConnectionKey() method added by JDK-8335181 [2].
test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java, test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java and test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java test classes are updated to add getConnectionKey() implementation
All jtreg tests for java.net.httpclient are passed
[1] - #1426
[2] - openjdk/jdk@720b446#diff-c18c2a070038409f25c08e13c174a95f33840e2deddcc29f6d8306de572a618b
Progress
Integration blocker
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1428/head:pull/1428
$ git checkout pull/1428
Update a local copy of the PR:
$ git checkout pull/1428
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1428/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1428
View PR using the GUI difftool:
$ git pr show -t 1428
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1428.diff
Using Webrev
Link to Webrev Comment