Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349039: Adjust exception No type named <ThreadType> in database #1429

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 24, 2025


Progress

  • JDK-8349039 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349039: Adjust exception No type named <ThreadType> in database (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1429/head:pull/1429
$ git checkout pull/1429

Update a local copy of the PR:
$ git checkout pull/1429
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1429/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1429

View PR using the GUI difftool:
$ git pr show -t 1429

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1429.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 24, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349039: Adjust exception No type named <ThreadType> in database

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d02ad34: 8327476: Upgrade JLine to 3.26.1
  • 9c26323: 8349729: [21u] AIX jtreg tests fail to compile with qvisibility=hidden

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 669f8c0c07b57fa00ac84b8a90c4a1a1459443e3 8349039: Adjust exception No type named <ThreadType> in database Feb 24, 2025
@openjdk
Copy link

openjdk bot commented Feb 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 24, 2025

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 24, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Feb 24, 2025
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

Going to push as commit 335b2f5.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d02ad34: 8327476: Upgrade JLine to 3.26.1
  • 9c26323: 8349729: [21u] AIX jtreg tests fail to compile with qvisibility=hidden

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 25, 2025
@openjdk openjdk bot closed this Feb 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@MBaesken Pushed as commit 335b2f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant