8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running

[fmeum]

Hi all,

This pull request contains a backport of commit af3f5d85 from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 15 Jan 2025 and was reviewed by Viktor Klang.

Thanks!

---

Progress

• JDK-8347039 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running (Bug - P3 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk24u.git pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/19.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fmeum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fmeum This change is no longer ready for integration - check the PR body for details.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @fmeum This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (7d7bc00e)

[fmeum]

/approval request Executors.newVirtualThreadPerTaskExecutor() is used frequently and prone to data races without this fix despite correct try-with-resources usage.

[openjdk]

@fmeum
8347039: The approval request has been created successfully.

[fmeum]

/integrate

[openjdk]

@fmeum
Your change (at version 7d7bc00) is now ready to be sponsored by a Committer.

[fmeum]

@AlanBateman Would you be available to sponsor this change? Should I also sent a backport request to 21?

[AlanBateman]

@AlanBateman Would you be available to sponsor this change? Should I also sent a backport request to 21?

It would be better to have the change bake in main line before thinking about back ports. So I think a bit premature to have a PR.

[fmeum]

Understood (sorry, I barely have any experience with backporting)! What would be a reasonable period after which we should revisit this?

[bridgekeeper]

@fmeum This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!