Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349943: [JMH] Use jvmArgs consistently #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 20, 2025

Hi all,

This pull request contains a backport of commit 3ebed783 from the openjdk/jdk repository.

The commit being backported was authored by Nicole Xu on 20 Feb 2025 and was reviewed by SendaoYan, Claes Redestad and Hao Sun.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349943 needs maintainer approval

Issue

  • JDK-8349943: [JMH] Use jvmArgs consistently (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.org/jdk24u.git pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/83.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3ebed78328bd64d2e18369d63d6ea323b87a7b24 8349943: [JMH] Use jvmArgs consistently Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix JMH test bugs which cause some JMH test fails. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@sendaoYan
8349943: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant