8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708

[zzambers]

sun/management/jmxremote/startstop/JMXStartStopTest.java fails on 8u after backport of JDK-8066708

Problem:

test_01 failed
java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at JMXStartStopTest.main(JMXStartStopTest.java:294)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
	at java.lang.Thread.run(Thread.java:750)
Caused by: java.rmi.NoSuchObjectException: no such object in table
	at sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303)
	at sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279)
	at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:380)
	at sun.rmi.registry.RegistryImpl_Stub.list(RegistryImpl_Stub.java:91)
	at JMXStartStopTest.testConnect(JMXStartStopTest.java:201)
	at JMXStartStopTest.testConnect(JMXStartStopTest.java:187)
	at JMXStartStopTest.test_01(JMXStartStopTest.java:503)
	... 11 more
java.lang.Error
	at JMXStartStopTest.main(JMXStartStopTest.java:318)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
	at java.lang.Thread.run(Thread.java:750)

JavaTest Message: Test threw exception: java.lang.Error
JavaTest Message: shutting down test

Fix:
There was a mistake in JDK-8066708 backport, where testConnect is called instead of testNoConnect. This PR fixes this.

Testing:

• tested locally, JMXStartStopTest.java passed with this change
• GHA test failures are unrelated

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8348211 needs maintainer approval

Issue

• JDK-8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708 (Bug - P4 - Approved)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/616/head:pull/616
$ git checkout pull/616

Update a local copy of the PR:
$ git checkout pull/616
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 616

View PR using the GUI difftool:
$ git pr show -t 616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/616.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
• fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
• 88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
• 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• 8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
• bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
• f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• 492acd3: 8265019: Update tests for additional TestNG test permissions
• 3683a81: Merge
• 129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
• ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (a7dee91b)

[ktakakuri]

I made the typo when I backported. I think this fix is correct.

[bridgekeeper]

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[zzambers]

keep open

[openjdk]

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[zzambers]

/approval request Fix to JMXStartStopTest.java test, safe, only modifies test

[openjdk]

@zzambers
8348211: The approval request has been created successfully.

[zzambers]

/integrate

[openjdk]

Going to push as commit 5ccff2c.
Since your change was applied there have been 14 commits pushed to the master branch:

• f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
• fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
• 88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
• 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• 8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
• bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
• f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• 492acd3: 8265019: Update tests for additional TestNG test permissions
• 3683a81: Merge
• 129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
• ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zzambers Pushed as commit 5ccff2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.