8339560: Unaddressed comments during code review of JDK-8337664

[jerboaa]

I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting JDK-8346587. The patch was mostly done by hand as it didn't apply cleanly.

Notable changes:

• /test/lib => /lib/security test library changes
• Manual renames of cert chains due to changed paths in JDK 8u
• Applied hunks manually to Distrust.java (rename from Entrust/Distrust.java as well).

Testing:

• Tests in sun/security/ssl/X509TrustManagerImpl

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8339560 needs maintainer approval

Issue

• JDK-8339560: Unaddressed comments during code review of JDK-8337664 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/626/head:pull/626
$ git checkout pull/626

Update a local copy of the PR:
$ git checkout pull/626
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 626

View PR using the GUI difftool:
$ git pr show -t 626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/626.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[jerboaa]

Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Entrust.java
Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Symantec.java
Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java
Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java
Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java
Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java
Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java
Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java
Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java
Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java
Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java
Test results: passed: 13

@franferrax @martinuy Could you please help review this, thanks!

[mlbridge]

Webrevs

• 00: Full (e8c86cc6)

[jerboaa]

GHA failures are the known certificate issues. Linux x86 is a known intermittent failure (gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java. MacOSX x64 are known problems as well (I think). Definitely all have nothing to do with this patch.

[zzambers]

MacOSX x64 are known problems as well (I think). Definitely all have nothing to do with this patch.

True, Mac failures are addressed by:
#580 (integrated)
#553