-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch repo to openmm org in download wheel script + other fixes #2
Open
mikemhenry
wants to merge
13
commits into
openmm:main
Choose a base branch
from
mikemhenry:cleanup-repo-xfer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
44c402f
switch repo to openmm org
mikemhenry 0e3e47c
patch in numpy as a dep
mikemhenry 06fc645
update action and allow overwrite
mikemhenry 2954fb3
update action and allow overwrite
mikemhenry 1e48642
adjust patch slightly since gh4498.patch modifies setup.py as well
mikemhenry 0678607
test to see if my patch is breaking everything
mikemhenry 3cb3a91
pin audit wheel
mikemhenry 568df8d
use unix and not linux to pin auditwheel
mikemhenry 348f3b7
duh auditwheel is a linux only thing
mikemhenry 60d1c5f
Fix lints
isuruf 24b7ef3
numpy<2
isuruf 93a1a0a
rerender
isuruf b3e46e3
use vault
isuruf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
|
||
|
||
- name: Upload artifacts to Github | ||
uses: actions/upload-artifact@v2 | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
path: build_artifacts/pypi_wheels | ||
name: ${{ matrix.CONFIG }} | ||
overwrite: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see issue #4 |
||
|
||
- name: Upload artifacts to Github release | ||
uses: svenstaro/upload-release-action@v2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/wrappers/python/setup.py b/wrappers/python/setup.py | ||
index f5de33531..da3ffd36a 100644 | ||
--- a/wrappers/python/setup.py | ||
+++ b/wrappers/python/setup.py | ||
@@ -166,6 +166,7 @@ def buildKeywordDictionary(major_version_num=MAJOR_VERSION_NUM, | ||
(especially on recent GPUs) that make it truly unique among simulation codes. | ||
""" | ||
setupKeywords["extras_require"] = {"cuda12": f"openmm-cuda=={setupKeywords['version']}.12", "cuda11.2": f"openmm-cuda=={setupKeywords['version']}.11.2", "cuda11.8": f"openmm-cuda=={setupKeywords['version']}.11.8"} | ||
+ setupKeywords["install_requires"] = ["numpy"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
define_macros = [('MAJOR_VERSION', major_version_num), | ||
('MINOR_VERSION', minor_version_num)] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ source: | |
patches: | ||
- 0001-wheels.patch | ||
- gh4498.patch | ||
- gh4537.patch | ||
|
||
build: | ||
number: {{ build }} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2 is getting deprecated in june so I figured might as well update now