Skip to content

Commit

Permalink
el-only variants: drop pungi-related comments
Browse files Browse the repository at this point in the history
It was an aspiration at the beginning of this effort to try to think of
these streams as kind of follow-on jobs to pungi composes that happen
in CentOS Stream and RHEL. And so I had an idea of matching exactly the
Pungi compose ID we were composing from to reinforce that.

In practice, it was quite awkward to query compose IDs and also do it in
a race-free way. It didn't seem worth the added complexity, so I backed
it out. It's also currently not clear what the future of Pungi is.

So let's just remove the comments related to it.
  • Loading branch information
jlebon committed Dec 12, 2024
1 parent 2293b96 commit 5f8ff1f
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions manifest-c9s.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ repos:
- c9s-baseos
- c9s-appstream

# Eventually we should try to build these images as part of the c9s composes.
# In that case, the versioning should instead be exactly the same as the pungi
# compose ID.
automatic-version-prefix: "9.0.<date:%Y%m%d>"
# This ensures we're semver-compatible which OpenShift wants
automatic-version-suffix: "-"
Expand Down
3 changes: 0 additions & 3 deletions manifest-rhel-9.4.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ repos:
- rhel-9.4-baseos
- rhel-9.4-appstream

# Eventually we should try to build these images as part of the RHEL composes.
# In that case, the versioning should instead be exactly the same as the pungi
# compose ID.
automatic-version-prefix: "9.4.<date:%Y%m%d>"
# This ensures we're semver-compatible which OpenShift wants
automatic-version-suffix: "-"
Expand Down
3 changes: 0 additions & 3 deletions manifest-rhel-9.6.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ repos:
- rhel-9.6-baseos
- rhel-9.6-appstream

# Eventually we should try to build these images as part of the RHEL composes.
# In that case, the versioning should instead be exactly the same as the pungi
# compose ID.
automatic-version-prefix: "9.6.<date:%Y%m%d>"
# This ensures we're semver-compatible which OpenShift wants
automatic-version-suffix: "-"
Expand Down

0 comments on commit 5f8ff1f

Please sign in to comment.