Skip to content

Commit

Permalink
overlay.d/05rhcos: Neuter coreos-luks-open for remote kdump
Browse files Browse the repository at this point in the history
In cases where kdump is configured to export logs to a remote machine,
mounting the local disk is pointless. Furthermore, we can't even do it.
This bug was hidden by kdump truncating the arguments but it surfaced
in 4.16 with rhkdump/kdump-utils@0f6ad91

See https://issues.redhat.com/browse/OCPBUGS-42351
See coreos/fedora-coreos-config@8ced0db#diff-c55c07c8d9cee0242ef457bc2d5cc254a1c1c1d53f2957378736efe1a98218c1R19
  • Loading branch information
jbtrystram committed Oct 8, 2024
1 parent b753d25 commit 96c24cc
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ add_requires() {
ln -sf "../${name}" "${requires_dir}/${name}"
}

# We don't need to mount the local disk if we are in the kdump initramfs
# and kdump is configured to export the logs to a remote target
# See https://issues.redhat.com/browse/OCPBUGS-42351
# Also see https://github.com/coreos/fedora-coreos-config/commit/8ced0db61f23a9b59ef096317fb6fc225bfba133
if getargbool 0 'kdump_remote_ip'; then
exit 0
fi

# In 4.4+, we only activate if rhcos.root=crypt_rootfs as set on the
# kernel cmdline by image.yaml. This will allow us to go back
# to matching FCOS and supporting full rootfs reprovisioning.
Expand Down

0 comments on commit 96c24cc

Please sign in to comment.