Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support for PrescribedController #3626

Closed
wants to merge 56 commits into from
Closed

[WIP] Support for PrescribedController #3626

wants to merge 56 commits into from

Conversation

nickbianco
Copy link
Member

@nickbianco nickbianco commented Nov 22, 2023 •
edited by aymanhab
Loading

Fixes issue #3605

Brief summary of changes

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...
  • updated.

This change is Reviewable

@nickbianco
Outline for PrescribedController support in Moco
d868133
@nickbianco
Update TropterProblem with new DiscreteController logic
22a96b1
@nickbianco
Properly handle non-scalar actuators
6ce6fad
@nickbianco
Update utilities functions for controls to account for user-added Con…
df78e9b 
…trollers
@nickbianco
Add sliding mass w/ PrescribedController test
31ea193
@nickbianco
Use bracket include
c0a857e
@nickbianco
Move DiscreteController to Simulation library
cc3a485
@nickbianco
Ignore .idea/editor.xml
157034a
@nickbianco
Update docs for skipping controller actuators in SimulationUtilities
a5059d7
@nickbianco
Update logic for excluding actuators associated with DiscreteControllers
2c2a3e9
@nickbianco
Double check that controls in DiscreteController are in the correct o…
e0484c6 
…rder
@nickbianco
Start refactoring crude first implementation: adding InputController …
679f817 
…and ActuatorInputController
@nickbianco
Exploring support for list Sockets
7a22f03
@nickbianco nickbianco mentioned this pull request Dec 13, 2023
Closed
@nickbianco
Merge branch 'main' into moco_prescribed_controllers
f8b0bcd
@nickbianco
Start converting Controller to use a list Socket
e9a8b14
@nickbianco
Convert to a list Socket for Controller actuators
2c305f4
@nickbianco
Merge branch 'list_sockets' into controller_actuators_list_socket
a2e1cce
@nickbianco
Last update after Controller changes needed for compilation
7e290ff
@nickbianco
Merge branch 'list_sockets' into controller_actuators_list_socket
7589d9c
@nickbianco
Various comments and formatting updates
fae7c57
@nickbianco
Figuring out how to deal with PrescribedController
f75caf5
@nickbianco
Merge branch 'main' into controller_actuators_list_socket
2770493
@nickbianco
Refactor PrescribedController
fdf9bd7
@nickbianco
Update changelog
fc174e8
@nickbianco
Fix changelog typos // remove TODOs
d99a811
@nickbianco
Support loading older XMl files
2b91515
@nickbianco
Add Controller interface tests
f81b279
@nickbianco
Minor formatting updates
609ce25
@nickbianco
Fix mixed type comparisons for failing Linux builds
0107fcb
@nickbianco
Support setting all actuators with 'ALL' flag
8d40b15
@nickbianco
Attempt to fix CMC tests
e22930b
@nickbianco
Continue fixing failing tests
70e51f0
@nickbianco
Fixing failing test pt.2
eaec8dd
@nickbianco
Fix broken connectee root issue in testForward
e4f664b
@nickbianco
Undo debugging code in AbstractTool for copied controllers
c82227f
@nickbianco
Fix testForward
3e0ded6
@nickbianco
Convert to int to avoid warnings treated as errors
3a895db
@nickbianco
Remove unnecessary addActuator() calls
196d342
@nickbianco
Remove arrays of ReferencePtrs
a4f47b6
@nickbianco
Merge branch 'controller_actuators_list_socket' into moco_prescribed_…
95e1246 
…controllers
@nickbianco
Switch to list Sockets for Controller actuators
f1687f2
@nickbianco
Add ControlAllocator // revert stuff in SimulationUtilities
7198b6e
@nickbianco
Update all goals after reverting SimulationUtilities
b5ba1bf
@nickbianco
Wiring everything together
b40bed1
@nickbianco
Use raw controls from ControlAllocator in solvers
8d74b5b
@nickbianco
Remove DiscreteController
7a6d422
@nickbianco
Revert sandbox changes
9d4c7c4
@nickbianco
Correct docs for ModelFactory sliding mass
a96551d
@nickbianco
Merge branch 'main' into controller_actuators_list_socket
6d25f08
@nickbianco
Respond to review comments
aaa4b71
@nickbianco
Merge branch 'controller_actuators_list_socket' of https://github.com…
495f289 
…/opensim-org/opensim-core into controller_actuators_list_socket
@nickbianco
Update change log and deprecated function message
a0d5717
@nickbianco
Add deprecated PrescribedController method to changelog
408a792
@nickbianco nickbianco changed the title [Moco] Support for PrescribedController [WIP] Support for PrescribedController Feb 8, 2024
@nickbianco nickbianco marked this pull request as ready for review February 8, 2024 22:39
@nickbianco nickbianco closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickbianco