-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types for methods in BufferedOrientationReference #3644
Conversation
Thanks for the nice contribution @RTnhN 👍 I will review the change and test case and get back to you shortly. |
Perfect, thank you very much, will merge once all tests pass. We'll need to update the repo by Patrick as well. I'd suggest you either open a PR there or open an issue and include your proposed code change so that future users of OpenSenseRT don't need to start from scratch. Thanks again 💯 |
Will merge this PR, thanks again for the contribution, in the meantime please document the changes you made for successful use of OpenSenseRT on an issue/PR in https://github.com/pslade2/RealTimeKin to help future fellow users. |
Awesome, thanks! I'll document my changes to that OpenSenseRT repo. |
* Add missing types * Add tests to check BufferedOrientationReference * Update CHANGELOG * Add test case for appending data to oRefs
* Add missing types * Add tests to check BufferedOrientationReference * Update CHANGELOG * Add test case for appending data to oRefs Co-authored-by: Zach Strout <[email protected]>
Fixes issue #3415
Brief summary of changes
The interface to BufferedOrientationReferene is defined here:
opensim-core/Bindings/simulation.i
Line 242 in 2aa34e1
In BufferedOrientationReference.h, there were missing
_<double>
type annotations forSimTK::RowVector_<SimTK::Rotation>
. I think that when swig pulled in the header file for defining the interface, it was not sure how to handle some methods including theputValues
since that did not have the_<double>
type on it. Ref: 26e9f22Also, I noticed that the python opensense testing file did not include any tests for the initialization of the
BufferedOrienationReference
, so I added some tests for that. To make sure that the ikSolver initializes well with theBufferedOrienationReference
, I also added a test using it to initialize it.Testing I've completed
I have built with these changes locally using the linux build script, and all tests have passed.
I have made minor changes to Patrick's code to incorporate the new
BufferedOrientationReference
, and it runs with no problems.Looking for feedback on...
CHANGELOG.md
This change is