Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change simbody to 589e931f #3650

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Change simbody to 589e931f #3650

merged 1 commit into from
Dec 14, 2023

Conversation

adamkewley
Copy link
Contributor

@adamkewley adamkewley commented Dec 13, 2023 •
edited by aymanhab
Loading

Changes simbody to this commit, which is explained in more detail in this PR.

Brief summary of changes

  • Changes vector growth related to reading vtp files etc., which should help with loading models files that use those mesh assets

Testing I've completed

  • I ran it in OSC on a patched OpenSim branch and it seems to do the trick

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because it's a minor perf change related to loading osim files

This change is Reviewable

@adamkewley adamkewley merged commit 0ea669c into main Dec 14, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickbianco nickbianco nickbianco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamkewley @nickbianco