Undo binding of model getCoordinatesInMultibodyTreeOrder and introduc… #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e getCoordinateNamesInMultibodyTreeOrder for scripting users
nickbianco
reviewed
Dec 19, 2023
nickbianco
requested changes
Dec 19, 2023
CHANGELOG.md
Outdated
| @@ -25,7 +25,7 @@ and `Blankevoort1991Ligament`, usages of `get_GeometryPath`, `upd_GeometryPath`, | |||
| - Deleting elements from an `OpenSim::Coordinate` range now throws an exception during `finalizeFromProperties` (previously: | |||
| it would let you do it, and throw later when `Coordinate::getMinRange()` or `Coordinate::getMaxRange()` were called, #3532) | |||
| - Added `FunctionBasedPath`, a class for representing paths in `Force`s based on `Function` objects (#3389) | |||
| - Fixed bindings to expose the method Model::getCoordinatesInMultibodyTreeOrder to scripting users (#3569) | |||
| - Fixed bindings to expose the method Model::getCoordinateNamesInMultibodyTreeOrder to scripting users (#3569) | |||
There was a problem hiding this comment.
Minor, but you've added a new method, so you could state that here and highlight that is scripting friendly.
| @@ -131,6 +131,8 @@ void testAssembleModelWithConstraints(string modelFile) | |||
| for(int i=0; i< coords.getSize(); i++) { | |||
| cout << "Coordinate " << coords[i].getName() << " get value = " << coords[i].getValue(state) << endl; | |||
| } | |||
| auto coordsInOrder = model.getCoordinateNamesInMultibodyTreeOrder(); | |||
| cout << coordsInOrder << std::endl; | |||
There was a problem hiding this comment.
Consider adding a simple check that coordsInOrder has the same size as the CoordinateSet.
nickbianco
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
LGTM.
Reviewed 1 of 3 files at r1, 2 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aymanhab)
nickbianco
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Reviewable status:
|
Thanks @nickbianco |
aymanhab
added a commit
that referenced
this pull request
Jan 10, 2024
#3656) * Undo binding of model getCoordinatesInMultibodyTreeOrder and introduce getCoordinateNamesInMultibodyTreeOrder for scripting users * Fix dereferencing the ReferencePtr and exercise in test case * Fix compilation warnings/errors on linux and call site to index the SimTKArray * Fix int/size_t mixup that causes compilation errors on linux * Update CHANGELOG.md Use updated function name * Address feedback on PR in test, changelog language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e getCoordinateNamesInMultibodyTreeOrder for scripting users
Fixes issue #0
Brief summary of changes
Using SimTK::ReferencePtr across binding was problematic due to methods optimized out. Adding a method to return names of coordinates instead to sidestep the memory management issue across the binding interface.
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is