Add rule-of-five to IKMarkerTask
and OrientationWeightSet
#3657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Adds move constructors, copy assignment operators, and move assignment operators to
IKMarkerTask
andOrientationWeightSet
. This suppressesgcc
compiler warnings complaining about no user-defined assignment operator when a user-defined copy-assignment operator is present.ProbeMeasure
issues a similar warning, but I think it can be ignored. It uses a Simbody macro to define custom copy assignment operators and copy constructors. The macro uses the termsshallowAssign
anddeepAssign
to define its copy constructors, since these do not use the typical constructor syntax,gcc
complains.Testing I've completed
CHANGELOG.md (choose one)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)