Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule-of-five to IKMarkerTask and OrientationWeightSet #3657

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

nickbianco
Copy link
Member

@nickbianco nickbianco commented Dec 19, 2023

Brief summary of changes

Adds move constructors, copy assignment operators, and move assignment operators to IKMarkerTask and OrientationWeightSet. This suppresses gcc compiler warnings complaining about no user-defined assignment operator when a user-defined copy-assignment operator is present.

ProbeMeasure issues a similar warning, but I think it can be ignored. It uses a Simbody macro to define custom copy assignment operators and copy constructors. The macro uses the terms shallowAssign and deepAssign to define its copy constructors, since these do not use the typical constructor syntax, gcc complains.

Testing I've completed

CHANGELOG.md (choose one)

  • no need to update because...not user facing.

This change is Reviewable

Copy link
Member

@aymanhab aymanhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @carmichaelong)

@aymanhab aymanhab merged commit ecdfba1 into main Dec 19, 2023
6 checks passed
@aymanhab aymanhab deleted the fix_rule_of_three_warnings branch December 19, 2023 22:50
@nickbianco
Copy link
Member Author

Thanks @aymanhab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants