Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[host] update directory name and namespace from ncp to host #2665

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Irving-cl
Copy link
Contributor

This PR changes the source directory name and namespace 'ncp' to 'host'.

The namespace and directory name is very confusing because under the namespace we have code and modules for both NCP & RCP case. The name was called 'ncp' since a long time ago. Now let's update.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.63%. Comparing base (2b41187) to head (0c27123).
Report is 916 commits behind head on main.

Files with missing lines Patch % Lines
tests/gtest/test_rcp_host_api.cpp 88.88% 5 Missing ⚠️
src/dbus/server/dbus_thread_object_ncp.cpp 0.00% 2 Missing ⚠️
src/agent/application.cpp 66.66% 1 Missing ⚠️
src/dbus/server/dbus_agent.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2665       +/-   ##
===========================================
- Coverage   55.77%   43.63%   -12.14%     
===========================================
  Files          87      106       +19     
  Lines        6890    13254     +6364     
  Branches        0      953      +953     
===========================================
+ Hits         3843     5784     +1941     
- Misses       3047     7163     +4116     
- Partials        0      307      +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for fixing this tech debt!

@Irving-cl Irving-cl requested a review from jwhui January 9, 2025 09:36
@jwhui jwhui requested a review from abtink January 9, 2025 16:26
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwhui jwhui merged commit 8bdfb6b into openthread:main Jan 13, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants