Pass through raptor changes #5249

Bartosz-Kruba · 2023-07-20T09:28:55Z

Summary

This PR includes all the necessary changes in Raptor module for handling PassThrough points via new C2 pareto-set parameter.

Issue

#4887

Unit tests

This PR includes all necessary tests for new functionality.

Documentation

Javadocs included.

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/ride/PatternRideFactory.java

src/main/java/org/opentripplanner/raptor/rangeraptor/path/DestinationArrivalPaths.java

src/main/java/org/opentripplanner/raptor/rangeraptor/context/SearchContext.java

src/main/java/org/opentripplanner/raptor/rangeraptor/path/PathParetoSetComparators.java

src/main/java/org/opentripplanner/raptor/rangeraptor/path/ReversePathMapper.java

src/test/java/org/opentripplanner/raptor/moduletests/ModuleTestDebugLogging.java

codecov · 2023-07-22T14:23:53Z

Codecov Report

Patch coverage: 90.35% and project coverage change: +0.13% 🎉

Comparison is base (1baa283) 66.08% compared to head (b68d4ae) 66.22%.
Report is 5 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5249      +/-   ##
=============================================
+ Coverage      66.08%   66.22%   +0.13%     
- Complexity     14942    15128     +186     
=============================================
  Files           1780     1787       +7     
  Lines          68969    69197     +228     
  Branches        7287     7348      +61     
=============================================
+ Hits           45576    45823     +247     
+ Misses         20905    20892      -13     
+ Partials        2488     2482       -6

Files Changed	Coverage Δ
...rg/opentripplanner/raptor/api/path/RaptorPath.java	`100.00% <ø> (+5.26%)`	⬆️
...raptor/multicriteria/McRangeRaptorWorkerState.java	`100.00% <ø> (ø)`
...ulticriteria/arrivals/c1/StopArrivalFactoryC1.java	`100.00% <ø> (ø)`
...ulticriteria/arrivals/c2/StopArrivalFactoryC2.java	`100.00% <ø> (+100.00%)`	⬆️
...eraptor/multicriteria/ride/PatternRideFactory.java	`100.00% <ø> (ø)`
...teria/ride/c2/TransitPriorityGroupRideFactory.java	`0.00% <ø> (ø)`
...ner/raptor/rangeraptor/path/ForwardPathMapper.java	`76.66% <0.00%> (-5.48%)`	⬇️
...va/org/opentripplanner/raptor/spi/UnknownPath.java	`66.66% <0.00%> (-2.30%)`	⬇️
...ain/java/org/opentripplanner/raptor/path/Path.java	`85.18% <40.00%> (-3.93%)`	⬇️
...a/org/opentripplanner/raptor/path/PathBuilder.java	`95.40% <50.00%> (-2.22%)`	⬇️
... and 27 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...tripplanner/raptor/rangeraptor/multicriteria/arrivals/ArrivalParetoSetComparatorFactory.java

src/main/java/org/opentripplanner/framework/lang/IntBox.java

src/main/java/org/opentripplanner/raptor/api/request/BitSetPassThroughPoints.java

src/main/java/org/opentripplanner/raptor/api/request/PassThroughPoints.java

src/main/java/org/opentripplanner/raptor/api/request/RaptorTransitPassThroughRequest.java

src/test/java/org/opentripplanner/raptor/moduletests/J01_PassThroughTest.java

src/test/java/org/opentripplanner/raptor/moduletests/support/ModuleTestDebugLogging.java

.../java/org/opentripplanner/raptor/rangeraptor/transit/ForwardRaptorTransitCalculatorTest.java

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/ride/PatternRide.java

src/main/java/org/opentripplanner/framework/lang/IntBox.java

.../java/org/opentripplanner/raptor/rangeraptor/transit/ForwardRaptorTransitCalculatorTest.java

src/main/java/org/opentripplanner/raptor/api/request/PassThroughPoints.java

...tripplanner/raptor/rangeraptor/multicriteria/arrivals/ArrivalParetoSetComparatorFactory.java

src/main/java/org/opentripplanner/raptor/rangeraptor/path/ForwardPathMapper.java

...tripplanner/raptor/rangeraptor/multicriteria/arrivals/ArrivalParetoSetComparatorFactory.java

src/main/java/org/opentripplanner/raptor/rangeraptor/path/PathParetoSetComparators.java

…minance function

Run Raptor module tests in debug mode if "debugRaptor" is set(any value) as a system property or an environment variable.

The Raptor package is self-contained and not even the test should reference outside OTP packages.

- Make C2 dominance function injectable - Write tests for PathParetoSetComparators.paretoComparator. All possible combinations

Co-authored-by: Johan Torin <[email protected]>

Bartosz-Kruba force-pushed the pass-through_raptor-changes branch 4 times, most recently from e9f2e4a to a6f1193 Compare July 20, 2023 12:38