fix(transitive-overlay): Prevent null route object from causing crash #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject causing crash
lightsage88
requested review from
binh-dam-ibigroup and
miles-grant-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on implementing a new data source to our Trimet application that includes new service providers, I noticed that sometimes the leg.route property was null but it was still coming up truthy for the if/else comparison I adjusted that checks whether or not it is an object. This was breaking some trips on different types of buses from new providers, but also our proprietary MAX Rail rides, which have never been a problem before.
This little fix ensures that route.leg is not null. When I did this locally, all my trips were working.