Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release dev under alpha and fix windows install #192

Conversation

berendsliedrecht
Copy link
Contributor

No description provided.

TimoGlastra
TimoGlastra previously approved these changes Oct 27, 2023
TimoGlastra
TimoGlastra previously approved these changes Oct 27, 2023
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, please also update the non-js dev versions

@berendsliedrecht
Copy link
Contributor Author

@andrewwhitehead any idea why this is failing (https://github.com/hyperledger/aries-askar/actions/runs/6692810757/job/18182849484)? I thought including the cargo.lock would make sure we use ring 16.x, but it fails on an issue for ring 17.x. The issue can be fixed by updating the containers GCC version (manylinux and android), but I am hoping for a slightly easier fix.

TimoGlastra
TimoGlastra previously approved these changes Oct 31, 2023
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht force-pushed the release-under-alpha-and-fix-windows branch 2 times, most recently from 05adc82 to 47b8227 Compare November 6, 2023 09:35
@andrewwhitehead andrewwhitehead merged commit 2bcc7e6 into openwallet-foundation:main Nov 9, 2023
27 checks passed
jamshale pushed a commit to jamshale/askar that referenced this pull request Aug 18, 2024
…lease-under-alpha-and-fix-windows

release dev under alpha and fix windows install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants