Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qr code component #170

Open
wants to merge 7 commits into
base: qr_code_component
Choose a base branch
from

Conversation

Deankinyua
Copy link

Created the qr code component successfully. Changed actions/upload-artifact@v2 to actions/upload-artifact@v4 because v2 is deprecated and cannot be used.

@almirsarajcic
Copy link
Member

For some reason, I can't see the component in the mobile screenshot.

Can you take a look at it?
https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/12752115351
Under Artifacts, you can download the screenshots and check them.

Is there a similar issue locally when you run the tests?

@Deankinyua
Copy link
Author

For some reason, I can't see the component in the mobile screenshot.

Can you take a look at it? https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/12752115351 Under Artifacts, you can download the screenshots and check them.

Is there a similar issue locally when you run the tests?

Yeah I have also not seen the mobile screenshot as well but I see it on my machine. Let me try to investigate the issue right now . Both screenshots exist locally

@Deankinyua
Copy link
Author

I have tried again but still the mobile screenshot is not reproduced during my workflows

@Deankinyua
Copy link
Author

I have realized what the issue is. The screenshot for mobile is being taken from the left side and in mobile view I have put the qr code component in the center

…...in mobile view the component is placed on the left side
@almirsarajcic
Copy link
Member

Screenshot 2025-01-14 at 09 11 29

qr_code_component-mobile

@Deankinyua
Copy link
Author

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants