-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qr code component #170
base: qr_code_component
Are you sure you want to change the base?
Qr code component #170
Conversation
For some reason, I can't see the component in the mobile screenshot. Can you take a look at it? Is there a similar issue locally when you run the tests? |
Yeah I have also not seen the mobile screenshot as well but I see it on my machine. Let me try to investigate the issue right now . Both screenshots exist locally |
I have tried again but still the mobile screenshot is not reproduced during my workflows |
I have realized what the issue is. The screenshot for mobile is being taken from the left side and in mobile view I have put the qr code component in the center |
…...in mobile view the component is placed on the left side
the latest run here has the changes https://github.com/Deankinyua/frontend_mentor_challenges/actions/runs/12762799352 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Created the qr code component successfully. Changed actions/upload-artifact@v2 to actions/upload-artifact@v4 because v2 is deprecated and cannot be used.