Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added framework to support embedding onnx model #1027

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

lu-ohai
Copy link
Member

@lu-ohai lu-ohai commented Dec 17, 2024

Added framework to support embedding onnx model

  • Added framework to support embedding onnx model
  • Updated user guide

Notebook

  • Tested on both CPU and GPU notebook instances
396269746-2e286220-6f3a-449b-b7b7-86599cccecec 396269749-36bc29ae-fcb5-4a52-b592-c9789d9846a9 396269752-7d0ebfca-fde6-4c2d-89da-04d322927597 396269755-e9875d2f-b329-4ea8-81d5-bfc8f5636e8b 396269758-38f2c20c-a19e-4620-a704-fd01909f5b68 396269760-f3f043b2-95f1-42af-a00c-dc680dc5339e 396269764-e6bb71fd-ab50-4b4c-a539-f456a9a2b25e 396269766-c6edbeff-6a9b-47c1-82d8-687362eafa82 396269769-3ab64c5b-18ee-459c-8896-a359abf619b0 396269771-69b4574e-2d1c-4556-a1cc-15b26496f42c 396269774-f6fe3031-f53c-4be8-a979-5579a0c9c89a 396269775-9d245d25-a9fd-4f26-9c85-440a9e5c3ff6 396269778-42240541-d667-432d-a91b-abf4250ee746

User Guide

396257974-961ff643-1c0d-451e-887e-942fd9605557 396281065-031f5d2f-ada7-445c-99b8-a4f32244e85c 396281068-b6c03bac-1f06-421d-9fde-6bce480e9f53 396257995-69687562-04d3-4cef-a471-b72c666eb452 396258001-acc66e35-aceb-4777-9193-52a5f2e961ad 396258008-3da5df9a-c854-48f4-9749-9ccda71ecdac 396258012-aa081d98-b3a7-49cf-aa15-285a03010c60 396258017-a99ac4b8-69d6-4152-b441-e4e807819d01

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 17, 2024
@lu-ohai lu-ohai changed the title Added framework to support embedding onnx model [WIP] Added framework to support embedding onnx model Dec 17, 2024
Copy link

📌 Cov diff with main:

Coverage-94%

📌 Overall coverage:

Coverage-58.53%

@lu-ohai lu-ohai marked this pull request as ready for review January 6, 2025 16:30
@lu-ohai lu-ohai changed the title [WIP] Added framework to support embedding onnx model Added framework to support embedding onnx model Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

📌 Cov diff with main:

Coverage-71%

📌 Overall coverage:

Coverage-58.47%

Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment to update the tokenizer list, rest looks good!

logger = logging.getLogger(__name__)

CONFIG = "config.json"
TOKENIZERS = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also include commonly used tokenizer files tokenizer.model, sentencepiece.bpe.model.
reference

@mrDzurb
Copy link
Member

mrDzurb commented Jan 11, 2025

Could you also attach the result of the raw-request?

Copy link

📌 Cov diff with main:

Coverage-46%

📌 Overall coverage:

Coverage-55.48%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants