Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set defaults for optional parameters in ChatOCIModelDeploymentVLLM #1037

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

qiuosier
Copy link
Member

@qiuosier qiuosier commented Jan 9, 2025

The ChatOCIModelDeploymentVLLM class contains inference parameters for vLLM APIs. However, updates on vLLM may remove some parameters, causing breaking change even if users do not use those parameters.

For example, the early_stopping parameter exist for v0.6.2 but it is removed since v0.6.3.

In the ChatOCIModelDeploymentVLLM class there is already logic to include parameters in the API request only if they are not None. However, since some of the parameters has a default value instead of None, they are added to the API request even though users did not intend to use them.

This PR sets the defaults of the optional parameters to None, so that they will not be added to the API request unless users specified them explicitly.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-57.28%

@VipulMascarenhas
Copy link
Member

@qiuosier I thought "autogen-agentchat~=0.2" would restrict it to 0.2.x, but seems it install 0.4.0 version for python 3.10+ but not for 3.9. The autogen and tf2onnx tests should be fixed if we change it to "autogen-agentchat<0.4".

@qiuosier
Copy link
Member Author

Thanks @VipulMascarenhas . I created a new PR for the autogen issue. @mrDzurb please suggest whether to merge this PR since your are testing the tool calling vllm image.

Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-57.28%

@qiuosier qiuosier merged commit b643faa into main Jan 13, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants