Set defaults for optional parameters in ChatOCIModelDeploymentVLLM #1037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChatOCIModelDeploymentVLLM
class contains inference parameters for vLLM APIs. However, updates on vLLM may remove some parameters, causing breaking change even if users do not use those parameters.For example, the
early_stopping
parameter exist for v0.6.2 but it is removed since v0.6.3.In the
ChatOCIModelDeploymentVLLM
class there is already logic to include parameters in the API request only if they are notNone
. However, since some of the parameters has a default value instead ofNone
, they are added to the API request even though users did not intend to use them.This PR sets the defaults of the optional parameters to None, so that they will not be added to the API request unless users specified them explicitly.