Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from m_reza_rahman #5112

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

edburns
Copy link
Contributor

@edburns edburns commented Oct 10, 2024

No description provided.

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 10, 2024
@edburns edburns force-pushed the edburns-msft-em-6234-reza-fixes branch 2 times, most recently from cb04982 to d5cfa5f Compare October 10, 2024 15:43
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 10, 2024
@edburns edburns marked this pull request as ready for review October 10, 2024 15:44
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Oct 10, 2024
mriccell
mriccell previously approved these changes Oct 10, 2024
@m-reza-rahman
Copy link

I just submitted the OCA. It should be simple enough to do and I think minimizes hassle going forward.

@m-reza-rahman
Copy link

@edburns, this is now ready to move forward. I have done at least one pass over everything.

Update model-in-image.md

Update prerequisites-01.txt

Update prerequisites-02.txt

Update prerequisites-01.txt

Update domain-on-pv.md

Update prerequisites-01.txt

Update create-resource-group.txt

Update create-aks-cluster-body-02.txt

Update create-aks-cluster-storage.txt

Update create-aks-cluster-storage.txt

Update create-aks-cluster-storage.txt

Update create-aks-cluster-storage.txt

Update domain-on-pv.md

Update run-mii-to-create-auxiliary-image.txt

Update create-acr.txt

Update domain-on-pv.md

Update domain-on-pv.md

Update domain-on-pv.md

Update domain-on-pv.md

Update domain-on-pv.md

Update clean-up-resources-body-01.txt

Update aks-connect-acr.txt

Update domain-on-pv.md

Update prerequisites-02.txt

Update prerequisites-01.txt

Update create-aks-cluster-body-01.txt

Update domain-on-pv.md

Update domain-on-pv.md

Update domain-on-pv.md

Update domain-on-pv.md

Update domain-on-pv.md

Update prerequisites-02.txt

Update prerequisites-01.txt

Update model-in-image.md

Update model-in-image.md

Update model-in-image.md

Update model-in-image.md

steps to accept the terms

Add files via upload

Update _index.md
@edburns edburns force-pushed the edburns-msft-em-6234-reza-fixes branch from dd65c38 to 1678873 Compare October 15, 2024 22:27
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 15, 2024
@edburns
Copy link
Contributor Author

edburns commented Oct 15, 2024

@galiacheng is going to push some more commits to fix the problems you identified, then we will advocate for merging this.

@galiacheng
Copy link
Contributor

@edburns @rjeberhard The PR is ready for review. Please note that this PR introduces changes to the sample script. Could you please refresh the sample-scripts.zip in v4.2.8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants