Skip to content

Commit

Permalink
fix: ensures the child template is not empty
Browse files Browse the repository at this point in the history
  • Loading branch information
mlmoravek committed Nov 26, 2024
1 parent 493a37e commit 383c433
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 24 deletions.
24 changes: 12 additions & 12 deletions packages/oruga/src/components/steps/StepItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,16 @@ const panelClasses = defineClasses(["stepPanelClass", "o-steps__panel"]);
:appear="parent.animateInitially"
@after-enter="afterEnter"
@before-leave="beforeLeave">
<template v-if="!parent.destroyOnHide || (isActive && visible)">
<div
v-show="isActive && visible"
v-bind="$attrs"
:id="`tabpanel-${item.identifier}`"
:class="panelClasses"
:data-id="`steps-${item.identifier}`"
data-oruga="steps-item"
:aria-labelledby="`tab-${item.identifier}`"
aria-roledescription="item">
<div
v-show="isActive && visible"
v-bind="$attrs"
:id="`tabpanel-${item.identifier}`"
:class="panelClasses"
:data-id="`steps-${item.identifier}`"
data-oruga="steps-item"
:aria-labelledby="`tab-${item.identifier}`"
aria-roledescription="item">
<template v-if="!parent.destroyOnHide || (isActive && visible)">
<!--
@slot Step item content
-->
Expand All @@ -199,7 +199,7 @@ const panelClasses = defineClasses(["stepPanelClass", "o-steps__panel"]);
<!-- default content prop -->
<template v-else>{{ content }}</template>
</slot>
</div>
</template>
</template>
</div>
</Transition>
</template>
24 changes: 12 additions & 12 deletions packages/oruga/src/components/tabs/TabItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,16 @@ const panelClasses = defineClasses(["tabPanelClass", "o-tabs__panel"]);
:appear="parent.animateInitially"
@after-enter="afterEnter"
@before-leave="beforeLeave">
<template v-if="!parent.destroyOnHide || (isActive && visible)">
<div
v-show="isActive && visible"
v-bind="$attrs"
:id="`tabpanel-${item.identifier}`"
:class="panelClasses"
:data-id="`tabs-${item.identifier}`"
data-oruga="tabs-item"
:aria-labelledby="`tab-${item.identifier}`"
aria-roledescription="item">
<div
v-show="isActive && visible"
v-bind="$attrs"
:id="`tabpanel-${item.identifier}`"
:class="panelClasses"
:data-id="`tabs-${item.identifier}`"
data-oruga="tabs-item"
:aria-labelledby="`tab-${item.identifier}`"
aria-roledescription="item">
<template v-if="!parent.destroyOnHide || (isActive && visible)">
<!--
@slot Tab item content
-->
Expand All @@ -195,7 +195,7 @@ const panelClasses = defineClasses(["tabPanelClass", "o-tabs__panel"]);
-->
<slot name="header" />
</template>
</div>
</template>
</template>
</div>
</Transition>
</template>

0 comments on commit 383c433

Please sign in to comment.