Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(switch): support w3c WAI-ARIA pattern #1131

Merged
merged 6 commits into from
Nov 25, 2024
Merged

feat(switch): support w3c WAI-ARIA pattern #1131

merged 6 commits into from
Nov 25, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Nov 23, 2024 •
edited
Loading

Proposed Changes

  • restructure Switch html structure to fix a11y issues
  • add aria-labelledBy with unique label id from wrapped Field component
  • add axe test cases

@mlmoravek mlmoravek added the a11y Accessibility label Nov 23, 2024
@mlmoravek mlmoravek mentioned this pull request Nov 23, 2024
Open
59 tasks
Base automatically changed from a11y/field to develop November 25, 2024 08:09
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 6b46279
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/67444cb345189700082ca105
😎 Deploy Preview https://deploy-preview-1131--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek merged commit 60ec0d1 into develop Nov 25, 2024
10 checks passed
@mlmoravek mlmoravek deleted the a11y/switch branch November 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a11y Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlmoravek