Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing saml group #4268

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: add missing saml group #4268

merged 1 commit into from
Jan 15, 2025

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 15, 2025

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from a team as a code owner January 15, 2025 13:13
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.62%. Comparing base (d4f96ce) to head (c0dbbb4).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4268      +/-   ##
==========================================
+ Coverage   78.59%   78.62%   +0.02%     
==========================================
  Files         381      381              
  Lines       27372    27372              
==========================================
+ Hits        21514    21522       +8     
+ Misses       4235     4231       -4     
+ Partials     1623     1619       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 44eb305 into master Jan 15, 2025
30 of 31 checks passed
@aeneasr aeneasr deleted the add-saml branch January 15, 2025 16:02
@ramu-n ramu-n mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant