Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more extension points #4272

Merged
merged 9 commits into from
Feb 3, 2025
Merged

feat: more extension points #4272

merged 9 commits into from
Feb 3, 2025

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jan 22, 2025

This adds more extension points to the Kratos registry.

@hperl hperl self-assigned this Jan 22, 2025
@hperl hperl requested review from aeneasr and a team as code owners January 22, 2025 14:10
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like provider became Provider in some files due to probably some refactoring. Also the API spec looks not fully correct yet. Otherwise LGTM

selfservice/strategy/oidc/pkce.go Outdated Show resolved Hide resolved
selfservice/strategy/oidc/strategy.go Outdated Show resolved Hide resolved
selfservice/strategy/oidc/strategy.go Outdated Show resolved Hide resolved
embedx/config.schema.json Outdated Show resolved Hide resolved
spec/api.json Show resolved Hide resolved
spec/api.json Outdated Show resolved Hide resolved
spec/api.json Outdated Show resolved Hide resolved
spec/api.json Outdated Show resolved Hide resolved
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous review

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 46.01770% with 61 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (7ca3b6b) to head (4ac0f42).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/oidc/strategy_registration.go 34.48% 18 Missing and 1 partial ⚠️
selfservice/strategy/oidc/strategy_login.go 42.85% 12 Missing ⚠️
selfservice/strategy/oidc/strategy.go 52.63% 9 Missing ⚠️
driver/registry_default.go 27.27% 4 Missing and 4 partials ⚠️
selfservice/strategy/oidc/provider_test_fedcm.go 80.00% 2 Missing and 2 partials ⚠️
selfservice/strategy/oidc/token_verifier.go 33.33% 2 Missing and 2 partials ⚠️
driver/registry.go 0.00% 3 Missing ⚠️
driver/registry_default_hooks.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4272      +/-   ##
==========================================
- Coverage   78.59%   78.55%   -0.04%     
==========================================
  Files         381      381              
  Lines       27382    27368      -14     
==========================================
- Hits        21521    21500      -21     
- Misses       4238     4244       +6     
- Partials     1623     1624       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

selfservice/strategy/oidc/provider_netid.go Outdated Show resolved Hide resolved
spec/api.json Outdated Show resolved Hide resolved
@zepatrik zepatrik merged commit 373a2e6 into master Feb 3, 2025
28 of 29 checks passed
@zepatrik zepatrik deleted the hperl/fedcm branch February 3, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants