Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #4273 - courier http channel - Include error response from email service provider in courier logs #4274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: #4273 - courier http channel - Include error response from email service provider in courier logs #4274

wants to merge 1 commit into from

Conversation

hvsharma
Copy link

4273 - courier http channel - Include error response from email service provider in courier logs

Related issue(s)

#4273

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hvsharma
4273 - courier http channel - Include error response from email servi…
2dc7bee 
…ce provider in courier logs

This change includes error response sent by email service provider when http channel is used and email sending fails due to some reason.

Currently only response code is included in courier logs when email sending api call is made. This makes it hard to obtain further information on the actual error.
@hvsharma hvsharma requested review from aeneasr and a team as code owners January 23, 2025 19:43
@CLAassistant
Copy link

CLAassistant commented Jan 23, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hvsharma hvsharma changed the title 4273 - courier http channel - Include error response from email service provider in courier logs feat-#4273 - courier http channel - Include error response from email service provider in courier logs Jan 23, 2025
@hvsharma hvsharma changed the title feat-#4273 - courier http channel - Include error response from email service provider in courier logs #4273 - feat - courier http channel - Include error response from email service provider in courier logs Jan 23, 2025
@hvsharma hvsharma changed the title #4273 - feat - courier http channel - Include error response from email service provider in courier logs feat: #4273 - courier http channel - Include error response from email service provider in courier logs Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvsharma @CLAassistant