Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept login_challenge in SPA verification flows #4284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas requested review from aeneasr and a team as code owners January 30, 2025 11:14
@jonas-jonas jonas-jonas self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.59%. Comparing base (07cb83c) to head (cde17c4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/flow/verification/handler.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4284      +/-   ##
==========================================
- Coverage   78.59%   78.59%   -0.01%     
==========================================
  Files         381      381              
  Lines       27370    27382      +12     
==========================================
+ Hits        21512    21521       +9     
- Misses       4236     4238       +2     
- Partials     1622     1623       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas requested a review from hperl January 30, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant