Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: use reporegistry.New() again (see PR#4378) #4582

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jan 29, 2025

This commit changes cmd/composer to use the reporegistry.New call again. This is a preparation for
osbuild/images#1179

And undoes parts of #4378 but that is no longer necessary because in
osbuild/images#946 the error is now passed on from reporegistry.New() in the same way as from LoadRepositories().

This commit changes cmd/composer to use the `reporegistry.New`
call again. This is a preparation for
osbuild/images#1179

And undoes parts of osbuild#4378
but that is no longer necessary because in
osbuild/images#946 the error is now passed
on from `reporegistry.New()` in the same way as from `LoadRepositories()`.
@mvo5 mvo5 requested a review from thozza January 29, 2025 09:58
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@thozza thozza enabled auto-merge (rebase) January 29, 2025 11:57
@thozza thozza merged commit 40011e3 into osbuild:main Jan 29, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants