many: update for new reporegistry.New() api (c.f. pr#1179) #4603
+2,036
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
from
2839201 to
4c84c2b
Compare
mvo5
requested review from
thozza,
schuellerf and
supakeen
and removed request for
a team
supakeen
previously approved these changes
Feb 10, 2025
thozza
reviewed
Feb 11, 2025
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
from
4c84c2b to
7b6d19e
Compare
schuellerf
force-pushed
the
update-api-for-images-pr1179
branch
from
7b6d19e to
c53ac1b
Compare
This commit updates osbuild-composer for the new API in images for the `reporegistry.New()`. The main incompatible change is that the `/repositories` part is not longer automatically added inside the library so we need to add it on the call-site. This needs osbuild/images#1179
This commit just runs `go vendor` and `git add`s the new content. It is required because in the previous commit we make use of the "real" repositories in the `compose_test.go` which mean they need to get added now (we only pulled in the test repos so far).
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
from
c53ac1b to
1c64f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates osbuild-composer for the new API in images for the
reporegistry.New(). The main incompatible change is that the/repositoriespart is not longer automatically added inside the library so we need to add it on the call-site.This needs osbuild/images#1179