Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipl: remove 'sdboot' image before generating new one #3379

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

nikita-dubrovskii
Copy link
Contributor

@nikita-dubrovskii nikita-dubrovskii commented Feb 3, 2025

Since s390-tools commit f4cf4ae6ebb1 (Remove genprotimg-C and switch to genprotimg-Rust implementation)
genprotimg is just a symlink to pvimg create, which by default doesn't overwrite the output image,
but introduces the --overwrite flag for this. Let's silently remove the file to support both tools.

Issue: openshift/os#1731

Copy link

openshift-ci bot commented Feb 3, 2025

Hi @nikita-dubrovskii. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cgwalters
Copy link
Member

But is there something that can be done on the s390-tools side to remain compatible? Shouldn't this be viewed as a bug?

@nikita-dubrovskii
Copy link
Contributor Author

But is there something that can be done on the s390-tools side to remain compatible? Shouldn't this be viewed as a bug?

This breaking change in pvimg tool was announced, so i doubt this new behaviour could be treated as a bug. Probably it was a bug-feature in the old genprotimg.

@sdodson
Copy link

sdodson commented Feb 3, 2025

Still seems like we should file a RHEL bug, we may not be the only folks relying on the old behavior and RHEL should know about it even if we choose to work around the change.

@cgwalters cgwalters merged commit 5dce645 into ostreedev:main Feb 3, 2025
24 checks passed
@nikita-dubrovskii nikita-dubrovskii deleted the pvimg branch February 3, 2025 18:18
@sdodson
Copy link

sdodson commented Feb 3, 2025

https://issues.redhat.com/browse/RHEL-77592 Just so anyone finding this later sees we filed a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants