fix: ensure frozen state on database and cache are in sync on !map #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minisbett
requested review from
cmyui,
skrungly,
NiceAesth,
tsunyoku and
7mochi
as code owners
tsunyoku
approved these changes
Sep 28, 2023
cmyui
reviewed
Sep 28, 2023
cmyui
reviewed
Nov 29, 2023
cmyui
reviewed
Nov 29, 2023
cmyui
approved these changes
Nov 29, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
cmyui
force-pushed
the
sync-cache-db-frozen
branch
from
a890d46 to
df26a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When using the
!mapcommand to update the status of a beatmap the map is always being frozen. Currently however, the code does set frozen to true in the database, but for the local cache it only updates the status.I noticed this when debugging #420 and this PR might offer the solution for that issue. I invalidated the cache when debugging (_cache_expired always returned true) which meant it's always being fetched from the api, which caused the status to be reverted because when checking whether it's frozen on the api check it wasn't (since it checks the cache where it was false, not the database where it's true).
Related Issues / Projects
Checklist
make lint)