Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: More clearly divide responsibilities of widely used ensure_local_osu_file function #559

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

cmyui
Copy link
Member

@cmyui cmyui commented Feb 4, 2024

Describe your changes

Related Issues / Projects

Checklist

  • I've manually tested my code

@cmyui cmyui force-pushed the score-submit-cleanup branch from 4ca327d to 773f35d Compare February 4, 2024 08:36
Base automatically changed from score-submit-cleanup to master February 4, 2024 08:44
@cmyui cmyui marked this pull request as ready for review February 6, 2024 06:18
@cmyui cmyui self-assigned this Feb 6, 2024
@cmyui cmyui added the code quality Something is implemented poorly label Feb 6, 2024
@cmyui cmyui force-pushed the refactor-ensure-local-osu-file branch from 024f7ab to 63b89ec Compare February 9, 2024 02:10
@cmyui cmyui changed the title Refactor: "ensure_local_osu_file" function Refactor: More clearly divide responsibilities of widely used ensure_local_osu_file function Feb 9, 2024
@cmyui cmyui force-pushed the refactor-ensure-local-osu-file branch from d69e7ab to 461ed8a Compare February 9, 2024 02:20
NiceAesth
NiceAesth previously approved these changes Feb 12, 2024
Copy link
Member

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@cmyui cmyui enabled auto-merge (squash) February 12, 2024 23:10
@cmyui cmyui merged commit 2913931 into master Feb 12, 2024
5 checks passed
@cmyui cmyui deleted the refactor-ensure-local-osu-file branch February 12, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Something is implemented poorly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants