-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: More clearly divide responsibilities of widely used ensure_local_osu_file
function
#559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyui
force-pushed
the
score-submit-cleanup
branch
from
February 4, 2024 08:36
4ca327d
to
773f35d
Compare
2 tasks
cmyui
commented
Feb 5, 2024
cmyui
requested review from
skrungly,
NiceAesth,
tsunyoku and
7mochi
as code owners
February 6, 2024 06:18
cmyui
force-pushed
the
refactor-ensure-local-osu-file
branch
from
February 9, 2024 02:10
024f7ab
to
63b89ec
Compare
cmyui
changed the title
Refactor: "ensure_local_osu_file" function
Refactor: More clearly divide responsibilities of widely used Feb 9, 2024
ensure_local_osu_file
function
cmyui
force-pushed
the
refactor-ensure-local-osu-file
branch
from
February 9, 2024 02:20
d69e7ab
to
461ed8a
Compare
NiceAesth
previously approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
NiceAesth
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related Issues / Projects
Checklist