Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add !clan join command #687

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

noemiowo
Copy link

Describe your changes

add a !clan join command.

Checklist

  • I've manually tested my code

@NiceAesth
Copy link
Member

i'm not sure if allowing anyone to join any clan is a good idea. the way i thought this would work is that you would invite someone if you have the required permissions then the join command would work as the "accept" invite command

app/commands.py Outdated Show resolved Hide resolved
@7ez
Copy link
Contributor

7ez commented Dec 27, 2024

i'm not sure if allowing anyone to join any clan is a good idea. the way i thought this would work is that you would invite someone if you have the required permissions then the join command would work as the "accept" invite command

maybe a !clan invite (along with !clan invite regen(erate)) which would allow the owner to generate (potentially stored in the clan obj) a random string and anyone who’d want to join would just do !clan join abc123?

@noemiowo
Copy link
Author

i'm not sure if allowing anyone to join any clan is a good idea. the way i thought this would work is that you would invite someone if you have the required permissions then the join command would work as the "accept" invite command

maybe a !clan invite (along with !clan invite regen(erate)) which would allow the owner to generate (potentially stored in the clan obj) a random string and anyone who’d want to join would just do !clan join abc123?

this could also be an idea, but that would require some more database modification to store clan invites and/or possibly ingame notifications of getting an invite, where the database part would be too much knowledge needed for me to add it, unless you'd have an idea on how to add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants